[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: fix broken quoting in the generated yacc grammar
From: |
Peter Rosin |
Subject: |
Re: [PATCH] tests: fix broken quoting in the generated yacc grammar |
Date: |
Sat, 18 Feb 2012 00:11:01 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.1) Gecko/20120208 Thunderbird/10.0.1 |
Stefano Lattarini skrev 2012-02-17 23:28:
> On 02/17/2012 10:15 PM, Peter Rosin wrote:
>> Fixes problem introduced by v1.11-1912-ge0906b7 "tests: avoid
>> spurious failure with non-bison yacc" from 12-02-2012.
>>
>> * tests/suffix10.tap (Makefile.am): Avoid outer single quotes
>> when we need to produce single quotes.
>> ---
>> tests/suffix10.tap | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> Hi!
>>
>> I stumbled on what seems like a trivial problem.
>>
> Oops, my bad. I've introduced this bug while recently tackling
> a portability weakness in the test case (see commit e0906b7e).
It's already referenced in the commit message :-)
>> But I'm not very fluent in yacc, so I thought I'd better ask
>> if this is the right fix... Is it? Ok for master?
>>
> Your fix looks good. ACK for master, and thanks.
Pushed, let me know if I shouldn't branch of from the "offending"
commit in the future.
Cheers,
Peter