automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: check the depmodes 'msvisualcpp' and 'msvcmsys'


From: Peter Rosin
Subject: Re: [PATCH] tests: check the depmodes 'msvisualcpp' and 'msvcmsys'
Date: Wed, 08 Feb 2012 13:52:55 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1

Stefano Lattarini skrev 2012-02-08 12:42:
> On 02/08/2012 11:03 AM, Peter Rosin wrote:
>> * tests/defs (cygpath): New requirement, checking that cygpath
>> is working.
>> (mingw): New requirement, checking that the build system is
>> MSYS (in its normal MinGW mode).
>> * tests/gen-testsuite-part (depmodes): Add entries for depmodes
>> 'msvisualcpp' and 'msvcmsys'.
>> ---
>>  tests/defs               |   10 ++++++++++
>>  tests/gen-testsuite-part |    4 ++++
>>  2 files changed, 14 insertions(+), 0 deletions(-)
>>
>> Hi!
>>
>> Can I assume that 'uname' works?
>>
> I guess so.  But see a suggestion for an extra-safety measure, below.
> 
>> If so, ok for master?
>>
> OK with the very minor nits below addressed.  And thanks!

Pushed with that addressed, thanks for looking!

Cheers,
Peter



reply via email to

[Prev in Thread] Current Thread [Next in Thread]