[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Alternatives for check8.test...
From: |
Peter Rosin |
Subject: |
Re: Alternatives for check8.test... |
Date: |
Thu, 02 Feb 2012 21:16:43 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 |
Stefano Lattarini skrev 2012-02-02 20:33:
> On 02/02/2012 08:16 PM, Peter Rosin wrote:
>> Hi!
>>
> Hi Peter.
>
>> When I run the testsuite with CC="cl -nologo" in the environment,
>> make -e in check8.test clobbers the rewritten CC (AM_PROG_CC_C_O
>> rewrites CC, remember?) causing the test to fail.
>>
>> I have two alternativ patches for this, one that makes the test
>> skip in this situation and one that makes it pass. I don't know
>> which you consider best, so I have included both version...
>>
> Actually, there is a much simpler approach: since 'AM_COLOR_TESTS'
> is *not* set in the automake-generated Makefiles, it is possible to
> override it from the environment *without* using the '-e' option
> of make. So, to solve your problem (and at the same time make the
> test unconditionally more robust) just drop the '-e' from the make
> call :-)
>
> Will you take care of reworking the patch, or should I do it?
The following is what I pushed (to maint).
Cheers,
Peter
Subject: [PATCH] tests: do not clobber the modified CC
If CC is originally a losing compiler, AM_PROG_CC_C_O will
modify CC. "$MAKE -e" will then clobber this modified CC
and reintroduce the raw losing compiler causing the test
to fail, as subdir-objects is in effect.
tests/check8.test: Drop -e from the $MAKE invocation, since
AM_COLOR_TESTS is not specified in the Makefile and -e is
therefore not needed.
---
tests/check8.test | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tests/check8.test b/tests/check8.test
index a9e5730..cbf1052 100755
--- a/tests/check8.test
+++ b/tests/check8.test
@@ -65,7 +65,7 @@ $AUTOCONF
$AUTOMAKE -a
./configure
-AM_COLOR_TESTS=always $MAKE -e check >stdout 2>stderr &&
+AM_COLOR_TESTS=always $MAKE check >stdout 2>stderr &&
{ cat stdout; cat stderr >&2; Exit 1; }
cat stdout
cat stderr >&2
--
1.7.5.1