Re: [PATCH 0/4] {master} maintainer checks: improve a little and reorganize

[Stefano Lattarini]

Hi Jim, thanks for the feedback.

On 01/29/2012 07:33 PM, Jim Meyering wrote:
> Stefano Lattarini wrote:
>> I will push this series to master in a couple of days if there is
>> no objection.
>>
>> Stefano Lattarini (4):
>>   maintcheck: refactor rules checking '*.am' files
>>   build: require GNU make to run the maintainer checks
>>   maintcheck: take advantage of some GNU make features
>>   maintcheck: fix real and spurious warnings
> 
> Those all look fine, at least upon cursory examination.
> 
>>   build: require GNU make to run the maintainer checks
> 
> The above would be slightly clearer if you were to insert "in order":
> 
>   build: require GNU make in order to run the maintainer checks
>
I like this too.  Consider it squashed in.

I've also tweaked the first paragraph in the commit message of the
second entry to read as follows:

  This is not a real regression in portability, since most maintainer
  check rules already assumed GNU grep, and were anyway only meant to
  run on the developers' systems (where we can safely assume the
  presence of GNU make).

> or to use "when running":
> 
>   build: require GNU make when running the maintainer checks
>
I will push the series later, once Peter's testsuite-related patches
have been applied.

Thanks,
  Stefano