Re: [FYI] {master} cosmetics: be more consistent in copyright notices in tests

[Stefano Lattarini]

Hi Dave, thanks for the review.

Luckily, I hadn't pushed this patch yet, so I can squash in the fixes for
the blunders you have pointed out, rather than having to apply them in a
follow-up.

On 12/27/2011 10:24 PM, Dave Hart wrote:
> On Tue, Dec 27, 2011 at 12:57, Stefano Lattarini
> <address@hidden> wrote:
>> diff --git a/lib/Automake/tests/Condition.pl 
>> b/lib/Automake/tests/Condition.pl
>> index e330e53..cf7d110 100644
>> --- a/lib/Automake/tests/Condition.pl
>> +++ b/lib/Automake/tests/Condition.pl
>> @@ -1,13 +1,11 @@
>> -# Copyright (C) 2001, 2002, 2003, 2009  Free Software Foundation, Inc.
>> +# Copyright (C) 2011 Free Software Foundation, Inc.
> 
> Was the omission of the earlier copyright years intentional?
>
No.  Fixed now.

> The others had 2011 added to the years list, not replacing it.
>
As it's correct.

>> diff --git a/tests/cond39.test b/tests/cond39.test
>> index f6a916e..52f95de 100755
>> --- a/tests/cond39.test
>> +++ b/tests/cond39.test
>> @@ -1,21 +1,18 @@
>>  #!/bin/sh
>>  # Copyright (C) 2008, 2010, 2011 Free Software Foundation, Inc.
>>  #
>> -# This file is part of GNU Automake.
>> -#
>> -# GNU Automake is free software; you can redistribute it and/or modify
>> +# This program is free software; you can redistribute it and/or modify
>>  # it under the terms of the GNU General Public License as published by
>>  # the Free Software Foundation; either version 2, or (at your option)
>>  # any later version.
>>  #
>> -# GNU Automake is distributed in the hope that it will be useful,
>> +# This program is distributed in the hope that it will be useful,
>>  # but WITHOUT ANY WARRANTY; without even the implied warranty of
>>  # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>  # GNU General Public License for more details.
>>  #
>>  # You should have received a copy of the GNU General Public License
>> -# along with Automake; see the file COPYING.  If not, write to
>> -# the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
>> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
>>  # Boston, MA 02110-1301, USA.
> 
> The way this diff reads, it appears the # Boston ... line above should
> have been removed along with the rest of the FSF postal address.  The
> same is true for several other files in this patch, which I haven't
> enumerated because I assume automation is being used to generate these
> patches
>
Honestly, I don't remember: most of the changes in this patch derives
from an earlier patch that have being lying around in my tree for some
time now.

> and will be used to correct this issue.
> 
The issues you have pointed out should be fixed now.

The updated patch is attached.  I will push briefly if there are no
further objections.

Thanks,
  Stefano

0001-cosmetics-be-more-consistent-in-copyright-notices-in.patch
Description: Text Data