automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[FYI] {maint} tests: fix failure due to debugging code forgotten into a


From: Stefano Lattarini
Subject: [FYI] {maint} tests: fix failure due to debugging code forgotten into a test
Date: Fri, 23 Dec 2011 13:09:16 +0100

* tests/missing-tar.test: Don't ever call the `missing' script
with `sh -x'; this was used for debugging, but an instance of
it slipped into the committed test case.  Bug revealed by a
failure on a Solaris 10 system with GNU tar installed as `gtar'.
---
 ChangeLog              |    8 ++++++++
 tests/missing-tar.test |    2 +-
 2 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 0a7a514..f080d2a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
 2011-12-22  Stefano Lattarini  <address@hidden>
 
+       tests: fix failure due to debugging code forgotten into a test
+       * tests/missing-tar.test: Don't ever call the `missing' script
+       with `sh -x'; this was used for debugging, but an instance of
+       it slipped into the committed test case.  Bug revealed by a
+       failure on a Solaris 10 system with GNU tar installed as `gtar'.
+
+2011-12-22  Stefano Lattarini  <address@hidden>
+
        missing: don't try to re-run tar with a munged command line
        * lib/missing: If the default `tar' program fails with the given
        arguments, and GNU tar is not available, don't try to re-run the
diff --git a/tests/missing-tar.test b/tests/missing-tar.test
index 4f531df..889ae20 100755
--- a/tests/missing-tar.test
+++ b/tests/missing-tar.test
@@ -142,7 +142,7 @@ $EGREP "(g|gnu)tar" stderr && Exit 1
 rm -f bin/*
 
 # We try to use an option that causes any `tar' program (GNU or non-GNU) to.
-sh -x ./missing --run tar --bad-unknonw-option cvf foo.tar ./data.txt 2>stderr 
\
+./missing --run tar --bad-unknonw-option cvf foo.tar ./data.txt 2>stderr \
   && { cat stderr >&2; Exit 1; }
 cat stderr >&2
 test ! -f foo.tar
-- 
1.7.7.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]