Re: [FYI] {test-protocols} test harness: recursive make invocations must use $(AM_MAKEFLAGS)

[Stefano Lattarini]

On Tuesday 09 August 2011, Stefano Lattarini wrote:
> * lib/am/check.am ($(TEST_SUITE_LOG)): Pass $(AM_MAKEFLAGS)
> to $(MAKE) when issuing a recursive make call.
> 
> Problem detected by the `sc_tests_make_without_am_makeflags'
> maintainer check.
> ---
>  ChangeLog       |    8 ++++++++
>  lib/am/check.am |    2 +-
>  2 files changed, 9 insertions(+), 1 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index c7f295b..0be0272 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,5 +1,13 @@
>  2011-08-09  Stefano Lattarini  <address@hidden>
>  
> +     test harness: recursive make invocations must use $(AM_MAKEFLAGS)
> +     * lib/am/check.am ($(TEST_SUITE_LOG)): Pass $(AM_MAKEFLAGS)
> +     to $(MAKE) when issuing a recursive make call.
> +     Problem detected by the `sc_tests_make_without_am_makeflags'
> +     maintainer check.
> +
> +2011-08-09  Stefano Lattarini  <address@hidden>
> +
>       tests: fix various blunders in 'suffix-chain.test'
>       * tests/suffix-chain.test: Fix various blunders that were causing
>       this test to fail spuriously: append to `configure.in', not to
> diff --git a/lib/am/check.am b/lib/am/check.am
> index 2b58c57..76c5273 100644
> --- a/lib/am/check.am
> +++ b/lib/am/check.am
> @@ -170,7 +170,7 @@ $(TEST_SUITE_LOG): $(TEST_LOGS)
>         redo_bases="$$redo_bases" \
>         redo_logs="$$redo_logs" \
>         redo_results="$$redo_results" \
> -         $(MAKE) am--redo-logs || exit 1; \
> +         $(MAKE) $(AM_MAKEFLAGS) am--redo-logs || exit 1; \
>       else :; fi;
>  ## We need a new subshell to work portably with "make -n", since the
>  ## previous part of the recipe contained a $(MAKE) invocation.
>
An consider this squashed-in:

diff --git a/lib/Automake/tests/Makefile.in b/lib/Automake/tests/Makefile.in
index fff8f6e..c898f49 100644
--- a/lib/Automake/tests/Makefile.in
+++ b/lib/Automake/tests/Makefile.in
@@ -375,7 +375,7 @@ $(TEST_SUITE_LOG): $(TEST_LOGS)
          redo_bases="$$redo_bases" \
          redo_logs="$$redo_logs" \
          redo_results="$$redo_results" \
-           $(MAKE) am--redo-logs || exit 1; \
+           $(MAKE) $(AM_MAKEFLAGS) am--redo-logs || exit 1; \
        else :; fi;
        @$(am__sh_e_setup); $(am__tty_colors); $(am__set_TESTS_bases); \
        ws='[   ]'; \
diff --git a/tests/Makefile.in b/tests/Makefile.in
index 7b1f59c..0d2bbf8 100644
--- a/tests/Makefile.in
+++ b/tests/Makefile.in
@@ -1530,7 +1530,7 @@ $(TEST_SUITE_LOG): $(TEST_LOGS)
          redo_bases="$$redo_bases" \
          redo_logs="$$redo_logs" \
          redo_results="$$redo_results" \
-           $(MAKE) am--redo-logs || exit 1; \
+           $(MAKE) $(AM_MAKEFLAGS) am--redo-logs || exit 1; \
        else :; fi;
        @$(am__sh_e_setup); $(am__tty_colors); $(am__set_TESTS_bases); \
        ws='[   ]'; \