Re: [FYI] {test-protocols} testsuite: fix spurious failure on Solaris make

[Stefano Lattarini]

On Sunday 07 August 2011, Stefano Lattarini wrote:
> * tests/test-driver-strip-vpath.test: Do not fail if "make -n"
> fails, as that is issued only for debugging, its semantic being
> tested in other test scripts.
> ---
>  ChangeLog                          |    7 +++++++
>  tests/test-driver-strip-vpath.test |    4 ++--
>  2 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index 86e565b..dc8bb93 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,5 +1,12 @@
>  2011-08-07  Stefano Lattarini  <address@hidden>
>  
> +     testsuite: fix spurious failure on Solaris make
> +     * tests/test-driver-strip-vpath.test: Do not fail if "make -n"
> +     fails, as that is issued only for debugging, its semantic being
> +     tested in other test scripts.
> +
> +2011-08-07  Stefano Lattarini  <address@hidden>
> +
>       tap driver: refactor and remove dead code
>       * lib/tap-driver (get_tap_line): Removed, ...
>       (all callers): ... updated to use $parser->next directly instead.
> diff --git a/tests/test-driver-strip-vpath.test 
> b/tests/test-driver-strip-vpath.test
> index 5b21cc0..7187abb 100755
> --- a/tests/test-driver-strip-vpath.test
> +++ b/tests/test-driver-strip-vpath.test
> @@ -79,7 +79,7 @@ mkdir build1
>  cd build1
>  ../src/configure
>  # "$MAKE -n" is for debugging, should highlight any VPATH rewrite.
> -$MAKE -n check
> +$MAKE -n check || :
>  $MAKE check
>  cd ..
>  
> @@ -87,7 +87,7 @@ mkdir build2
>  cd build2
>  "$ocwd"/src/configure
>  # "$MAKE -n" is for debugging, should highlight any VPATH rewrite.
> -$MAKE -n check
> +$MAKE -n check || :
>  $MAKE check
>  cd ..
>  
> 
Sorry, ESENDTOOSOON.  Consider the diff below squashed in.

Regards,
  Stefano

-*-*-*-

diff --git a/ChangeLog b/ChangeLog
index dc8bb93..1f77ef2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,9 +1,10 @@
 2011-08-07  Stefano Lattarini  <address@hidden>
 
-       testsuite: fix spurious failure on Solaris make
-       * tests/test-driver-strip-vpath.test: Do not fail if "make -n"
-       fails, as that is issued only for debugging, its semantic being
-       tested in other test scripts.
+       testsuite: fix two spurious failures on Solaris make
+       * tests/tests-environment-and-log-compiler.test: Do not fail if
+       "make -n check" fails, as that is issued only for debugging, its
+       semantics being tested in other test scripts.
+       * tests/test-driver-strip-vpath.test: Likewise.
 
 2011-08-07  Stefano Lattarini  <address@hidden>
 
diff --git a/tests/tests-environment-and-log-compiler.test 
b/tests/tests-environment-and-log-compiler.test
index 3753bb9..eafc3bf 100755
--- a/tests/tests-environment-and-log-compiler.test
+++ b/tests/tests-environment-and-log-compiler.test
@@ -65,7 +65,7 @@ $AUTOMAKE -a
 
 ./configure
 
-$MAKE -n check # For debugging.
+$MAKE -n check || : # For debugging.
 VERBOSE=yes $MAKE check
 cat a.log
 cat b.log