automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug#9147: 6 test failures on Fedora 15 with latest from git


From: Stefano Lattarini
Subject: Re: bug#9147: 6 test failures on Fedora 15 with latest from git
Date: Sun, 24 Jul 2011 11:26:45 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

On Saturday 23 July 2011, Stefano Lattarini wrote:
> > >> FAIL: txinfo21.test (exit: 1)
> > >> =============================
> > ...
> > >> + test -d rec/main3.html
> > >> + is_newest main.html main.texi
> > >> ++ find main.html main.texi -newer main.html
> > >> + is_newest_files=main.html/index.html
> > >> + test -z main.html/index.html
> > >> + exit_status=1
> > >> + set +e
> > >> + cd /h/j/w/co/automake/tests
> > >> + case $exit_status,$keep_testdirs in
> > >> + test 0 '!=' 0
> > >> + echo 'txinfo21: exit 1'
> > >> txinfo21: exit 1
> > >> + exit 1
> > >>
> > > Ah, a failure I've introduced in 'maint' with commit `v1.11-360-ga370e2f'
> > > "tests: fix spurious failure of txinfo21.test on FreeBSD".  It is due
> > > to a limitation of the `is_newest' subroutine I hadn't thought about
> > > (i.e., it doesn't work as expected on directories).  Should we hack
> > > around this, or try to fix the `is_newest' subroutine instead?  I think
> > > fixing `is_newest' is the best route. Anyway, I'll be AFK until tomorrow,
> > > but then I'll give it a try (unless someone wants to beat me ;-)
> > 
> >
> Fixed by the attached patch (tested with GNU find and Solaris find).
> I will allow a day or so for comments before pushing.
> 
Pushed now.  I'm thus closing this bug report.

Thanks,
  Stefano




reply via email to

[Prev in Thread] Current Thread [Next in Thread]