Re: [PATCH] {maint} remake: behave better with non-GNU make in subdirectories

[Peter Rosin]

Den 2011-05-29 19:32 skrev Stefano Lattarini:
> Hi Peter, thanks for the review.

I wouldn't call it review, it was more of a knee-jerk reaction
(and I haven't even read the actual patch).

> On Sunday 29 May 2011, Peter Rosin wrote:
>> Den 2011-05-29 16:26 skrev Stefano Lattarini:
>>> Currently, every decent non-GNU make program makes it possible
>>> to remake out-of-date autotools-generated files with a simple
>>> "make Makefile" issued from the top-level directory.  And while
>>> having to run "make Makefile" by hand isn't as convenient as
>>> the GNU make feature of "automatic remake *and reloading* of
>>> out-of-date makefiles", it is usually good enough and definitely
>>> worth having.
>>>
>>> Unfortunately, a silly limitation in the current implementation
>>> of remake rules prevents this idiom from working when it's used
>>> outside the top-level directory.  Luckily, this limitation is
>>> easy to     remove, and that's what this patch does.
>>
>> Nitpick: The tense is wrong for a ChangeLog entry, and there's a tab
>> in there as well.  Suggestion:
>>
>>      Remove silly limitation that prevents this idiom from
>>      working outside the top-level directory.
>>
>> I'm not sure if the essay style of the first paragraph should stay
>> or go though?
>>
> I mostly agree with your objections.  What do you think about this
> ChangeLog entry instead?

Hmmm, it just feels like you have identified some problem, and then
you proceed to writing a patch.  Then you write some words to
tell the world about the problem and the solution and put it all in
the ChangeLog.  It feels backwards to have the *original* problem
description in the ChangeLog, but I'm no longer sure if it's really
all that bad or if it just feels backwards _to_me_.

And regarding the tense, now that I think of it that's probably only
the rule for the actual changes in the asterisk lines, not the "header",
so that was probably off base too.  Not sure though.

Me feels bad, sorry for the interruption.  I lost the confidence
to voice my opinion...

Cheers,
Peter