[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[FYI] {testsuite-works} tests skips: shorter and clearer messages
From: |
Stefano Lattarini |
Subject: |
[FYI] {testsuite-works} tests skips: shorter and clearer messages |
Date: |
Sun, 1 May 2011 16:54:46 +0200 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
* tests/defs: Use shorter messages when giving reasons for test
skipping; it turns out these shorter messages are also clearer.
If more info might be useful, send them to the log file only.
---
ChangeLog | 7 +++++++
tests/defs | 18 ++++++++++--------
2 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index c629fe0..0851b77 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
2011-05-01 Stefano Lattarini <address@hidden>
+ tests skips: shorter and clearer messages
+ * tests/defs: Use shorter messages when giving reasons for test
+ skipping; it turns out these shorter messages are also clearer.
+ If more info might be useful, send them to the log file only.
+
+2011-05-01 Stefano Lattarini <address@hidden>
+
tests: fix self check spurious failure with older bash versions
* tests/self-check-cleanup.test: Add trailing `:' to the test code
passed to $SHELL, otherwise older versions of bash (at least 2.05
diff --git a/tests/defs b/tests/defs
index 9f862af..8c2b084 100644
--- a/tests/defs
+++ b/tests/defs
@@ -441,8 +441,7 @@ case $testbuilddir in
*\ *|*\ *)
case " $required " in
*' libtool '* | *' libtoolize '* )
- skip_ "libtool and libtoolize cannot cope correctly" \
- "with spaces in the build tree";;
+ skip_ "libtool has problems with spaces in builddir name";;
esac
;;
esac
@@ -455,8 +454,7 @@ case $testsrcdir in
*\ * |*\ *)
case " $required " in
*' libtool '* | *' libtoolize '* | *' gettext '* )
- skip_ "our testsuite setup cannot cope with spaces in the" \
- "source tree name for libtool/gettext tests.";;
+ skip_ "spaces in srcdir name: libtool/gettext tests won't work";;
esac
;;
esac
@@ -493,14 +491,18 @@ case " $required " in
case " $required " in
*' libtool '*|*' libtoolize '*)
if test $libtool_found != yes; then
- skip_ "libtool is required, but libtool.m4 wasn't found in" \
- "directories $aclocaldir $extra_includes"
+ # Write more diagnostic to the log file than to the console.
+ echo "$me: \`libtool.m4' wasn't found in directories" \
+ "$aclocaldir $extra_includes"
+ skip_ "libtool m4 macros won't be found by aclocal"
fi
;;
*' gettext '*)
if test $gettext_found != yes; then
- skip_ "gettext is required, but gettext.m4 wasn't found in" \
- "directories $aclocaldir $extra_includes"
+ # Write more diagnostic to the log file than to the console.
+ echo "$me: \`gettext.m4' wasn't found in directories" \
+ "$aclocaldir $extra_includes"
+ skip_ "gettext m4 macros won't be found by aclocal"
fi
;;
esac
--
1.7.2.3
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [FYI] {testsuite-works} tests skips: shorter and clearer messages,
Stefano Lattarini <=