automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing


From: Stefano Lattarini
Subject: Re: [PATCH] {maint} tests: new subroutines for test skipping/failing
Date: Sun, 17 Apr 2011 21:05:09 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

On Sunday 17 April 2011, Ralf Wildenhues wrote:
> Hello Stefano,
>
> * Stefano Lattarini wrote on Sun, Apr 17, 2011 at 03:27:17PM CEST:
> > Reference:
> >   <http://lists.gnu.org/archive/html/automake-patches/2011-03/msg00052.html>
> > 
> > On Wednesday 30 March 2011, Stefano Lattarini wrote:
> > > > > >   $(AM_TESTS_SETUP) $(TESTS_SETUP) $(TESTS_ENVIRONMENT)
> 
> I think the AM_TESTS_SETUP naming is not a good one.  It may be
> technically more correct than AM_TESTS_ENVIRONMENT, but I think
> the latter is the better one simply because it is easier to remember,
> and even if you've never heard of it and only know the semantics of
> TESTS_ENVIRONMENT, you can have a straightforward way to figure out
> how AM_TESTS_ENVIRONMENT would work.
> 
> Can we agree to rename it?
>
No problem, the important thing for me is to have that variable available
ASAP, with one name or another (and your choice of a name is backed up by
good reasons too, BTW).  I'm probably going offline shortly, but I'll do
the rename tomorrow (if you don't want to beat me at it).

> Sorry for jumping out now, and for not coming forward with a review
> earlier.
>
No big deal -- there's no release planned in the next days, so IMHO
we can afford a little more churn if that helps to get things done.

Regards,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]