automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] yacc: update NEWS w.r.t. Yacc-generated headers extesion


From: Ralf Wildenhues
Subject: Re: [PATCH 1/2] yacc: update NEWS w.r.t. Yacc-generated headers extesions
Date: Sun, 10 Apr 2011 11:04:49 +0200
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Sun, Apr 10, 2011 at 10:46:33AM CEST:
> OK for yacc-work?  I will push in 72 hours if there is no objection.

OK with nits addressed.  You can squash both changes together.

> Subject: [PATCH 1/2] yacc: update NEWS w.r.t. Yacc-generated headers extesions

> --- a/NEWS
> +++ b/NEWS
> @@ -5,9 +5,20 @@ New in 1.11.0a:
>    - The `lzma' compression scheme and associated automake option `dist-lzma'
>      is obsoleted by `xz' and `dist-xz' due to upstream changes.
>  
> +* Changes to Yacc support:
> +
>    - C source and header files derived from non-distributed Yacc sources are
>      now removed by "make clean", not only by "make maintainer-clean".
>  
> +  - Slightly backward-incompatible change, relevant only for use of Yacc
> +    with C++: the extensions of the header files produced by the Yacc
> +    rules are now modelled after extension of the sources corresponding
> +    sources.  For example, yacc files named "foo.y++" and "bar.yy" will
> +    produce header files named respectively "foo.h++" and "bar.hh", where
> +    they would have previously produced header files named simply "foo.h"
> +    and "bar.h".  This change offers a better compatibility with the

s/ a / /

> +    results of `bison -o' calls.

s/the result of `bison -o' calls/`bison -o'/

* Stefano Lattarini wrote on Sun, Apr 10, 2011 at 10:46:48AM CEST:
> Subject: [PATCH 2/2] yacc: update docs w.r.t. extension of yacc-generated 
> headers
> 
> * doc/automake.texi (Yacc and Lex): Document explicitly that
> extensions of yacc-generated headers are modelled after
> extension of the corresponding sources.

> --- a/doc/automake.texi
> +++ b/doc/automake.texi
> @@ -6048,10 +6048,14 @@ cause the intermediate file to be named @file{foo.c} 
> (as opposed to
>  @file{y.tab.c}, which is more traditional).
>  
>  The extension of a yacc source file is used to determine the extension
> -of the resulting C or C++ file.  Files with the extension @file{.y}
> -will be turned into @file{.c} files; likewise, @file{.yy} will become
> address@hidden; @file{.y++}, @file{c++}; @file{.yxx}, @file{.cxx}; and
> address@hidden, @file{.cpp}.
> +of the resulting C or C++ source and header file(s) (note that header

s/file(s)/files./
Start a new sentence after that, no need to put it in parentheses.

> +files are generated only when the @option{-d} Yacc option is used; see
> +below for more information about this flag, and how to specify it).
> +Files with the extension @file{.y} will be turned into @file{.c}
> +sources and @file{.h} headers; likewise, @file{.yy} will become
> address@hidden and @file{.hh}; @file{.y++}, @file{c++} and @file{h++};

... @file{.hh}, @file{.y++} will become @file{c++} and @file{h++},
..., and @file{.ypp} will become @file{.cpp} and @file{.hpp}.

> address@hidden, @file{.cxx} and @file{.hxx}; and @file{.ypp}, @file{.cpp}
> +and @file{.hpp}.
>  
>  Likewise, lex source files can be used to generate C or C++; the

Here, I'd continue with "Similarly," now.

>  extensions @file{.l}, @file{.ll}, @file{.l++}, @file{.lxx}, and

Thanks,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]