automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {master} tests: remove useless sleep from tests on remake ru


From: Stefano Lattarini
Subject: Re: [PATCH] {master} tests: remove useless sleep from tests on remake rules
Date: Sat, 9 Apr 2011 14:02:10 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

On Saturday 09 April 2011, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Apr 03, 2011 at 11:05:54AM CEST:
> > On Sunday 03 April 2011, Ralf Wildenhues wrote:
> > > * Stefano Lattarini wrote on Sun, Apr 03, 2011 at 10:23:57AM CEST:
> > > > The sleeps were there to make generated autotools files strictly
> > > > newer than their sources; however, this is not necessary, since
> > > > POSIX mandates that make considers files with the same timestamp
> > > > of their dependencies to be up-to-date.
> > > 
> > > info Autoconf "Timestamps and Make", in git Autoconf, tells you why
> > > these are good for HP-UX make.
> > >
> > Yes, but the worst that can happen would be that the first $MAKE
> > call is not really a no-op, and some autotools files get rebuilt.
> 
> Ah ok.
> 
> > Also, the involved tests currently require GNU make anyway.
> 
> Oh, then my argument is moot.
> 
> > But
> > I'm planning to enhance them to work with non-GNU make too, so
> > this objection is moot.
> 
> Then not any more.  ;-)
> 
> So, up to you I guess.
>
Having the "remake" tests working with more make implementations than
just GNU make is IMHO more important than avoiding a couple of sleeps
in our already-slow testsuite.  I will thus drop the patch for the
moment.  It can always be reproposed at a later date if interest in
it resurfaces.

Regards,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]