Re: [PATCH] {yacc-work} coverage: more on 'yacc -d' and recovery from deleted headers

[Ralf Wildenhues]

* Stefano Lattarini wrote on Fri, Jan 28, 2011 at 05:01:11PM CET:
> OK for the 'yacc-work' branch?  I will push in 72 hours if
> there's no objection.

OK with nits addressed.

FYI, I think the test has some overlap with one of the make -n tests
that ensures the deleted header recovery doesn't build files in dry
run mode.

Thanks,
Ralf

> coverage: more on 'yacc -d' and recovery from deleted headers
> 
> * tests/yacc-deleted-headers.test: New test.
> * tests/Makefile.am (TESTS): Update.

> diff --git a/tests/yacc-deleted-headers.test b/tests/yacc-deleted-headers.test
> new file mode 100644

Please fix the mode to be 755.

> index 0000000..f47b70e
> --- /dev/null
> +++ b/tests/yacc-deleted-headers.test

> +# Tests that we can recover from deleted headers generated by `yacc -d'.
> +
> +required=yacc
> +. ./defs || Exit 1
> +
> +set -e
> +
> +cat >> configure.in << 'END'
> +AC_PROG_CC
> +AC_PROG_YACC
> +AC_OUTPUT
> +END
> +
> +cat > Makefile.am <<'END'
> +bin_PROGRAMS = p1 p2 p3 p4
> +p1_SOURCES = parse1.y main1.c
> +p2_SOURCES = parse2.y main2.c
> +p3_SOURCES = parse3.y main3.c parse3.h
> +p4_SOURCES = parse4.y
> +AM_YFLAGS = -d
> +p2_YFLAGS = -d
> +BUILT_SOURCES = parse1.h p2-parse2.h

Interestingly, the test also passes for me when I omit the BUILT_SOURCES
line.  Bug in the test or just incidental?  If the latter, then ok, if
the former, then please add coverage for this.  Thanks.


> +# parse4.h is not declared in any *_SOURCES variable, nor
> +# #included by any C source file, so that it shouldn't be

s/that //

> +# rebuilt by "make all".
> +test ! -r parse4.h