automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Improvements and extend tests on canonicalization.


From: Stefano Lattarini
Subject: Re: [PATCH] Improvements and extend tests on canonicalization.
Date: Fri, 17 Dec 2010 00:42:50 +0100
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

On Thursday 16 December 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Thu, Dec 16, 2010 at 08:16:25PM CET:
> > On Thursday 16 December 2010, Ralf Wildenhues wrote:
> > > --- a/tests/canon7.test
> > > +++ b/tests/canon7.test
> > > @@ -43,7 +43,7 @@ dummy_dynamic_SOURCES = $(dummy_static_SOURCES)
> > >  dummy_static_LDADD = $(noinst_LIBRARIES)
> > >  dummy_dynamic_LDADD = $(noinst_LTLIBRARIES)
> > >  
> > > -_foo_bar_SOURCES = libs.c
> > > +_foo_bar_SOURCES = libs.c foobar.c
> > >
> > "_foo_bar_SOURCES = foobar.c" should suffice here.
> 
> Feel free to fix that.
>
Below's what I pushed.  I tested it with both GCC and Sun Studio
C compiler, both before and after merging to master.  I hope this
will avoid me another embarassing blunder.

Regards,
   Stefano

-*-*-*-

Minor cleanups in canon7.test.

* tests/canon7.test (_foo_bar_SOURCES): Remove libs.c.
(configure.in): Remove AC_PROG_CXX.
---
 ChangeLog         |    6 ++++++
 tests/canon7.test |    3 +--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 9386d80..cb8c207 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-12-17  Stefano Lattarini  <address@hidden>
+
+       Minor cleanups in canon7.test.
+       * tests/canon7.test (_foo_bar_SOURCES): Remove libs.c.
+       (configure.in): Remove AC_PROG_CXX.
+
 2010-12-16  Ralf Wildenhues  <address@hidden>
 
        Fix canon7.test failure.
diff --git a/tests/canon7.test b/tests/canon7.test
index 3f25d6f..b85a835 100755
--- a/tests/canon7.test
+++ b/tests/canon7.test
@@ -23,7 +23,6 @@ set -e
 
 cat >> configure.in << 'END'
 AC_PROG_CC
-AC_PROG_CXX
 AC_PROG_RANLIB  dnl: for static libraries
 AC_PROG_LIBTOOL dnl: for libtool libraries
 AC_OUTPUT
@@ -43,7 +42,7 @@ dummy_dynamic_SOURCES = $(dummy_static_SOURCES)
 dummy_static_LDADD = $(noinst_LIBRARIES)
 dummy_dynamic_LDADD = $(noinst_LTLIBRARIES)
 
-_foo_bar_SOURCES = libs.c foobar.c
+_foo_bar_SOURCES = foobar.c
 libb_az_baz_a_SOURCES = libs.c
 lib_zardoz___la_SOURCES = libd.c
 
-- 
1.7.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]