Re: [PATCH 4/5] Tests defs: avoid some useless subshells.

[Ralf Wildenhues]

* Stefano Lattarini wrote on Sat, Nov 20, 2010 at 02:14:57PM CET:
> On Saturday 20 November 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:26:05PM CET:
> > >        # Generic case: the tool must support --version.
> > >        echo "$me: running $tool --version"
> > > -      ( $tool --version ) || exit 77
> > > +      $tool --version || exit 77
> > 
> > It is not likely but possible that $tool is a special builtin, in which
> > case the shell is allowed to exit after an error.  Please leave the
> > subshell here.
> > 
> Good catch; I'll add a comment to explain why the subshell is needed
> in this case.

Good idea.

> BTW, it's ok if I add also your name to the ChangeLog entry?

Sure, if you like, but I didn't really contribute all that much to this
patch.  :-P

Cheers,
Ralf