Re: [PATCH 7/7] Tests defs: move static definitions in a new file `minidefs'.

[Ralf Wildenhues]

* Stefano Lattarini wrote on Sun, Nov 07, 2010 at 04:29:27PM CET:
> Tests defs: move static definitions in a new file `minidefs'.

minidefs is not a good name, as it is bound to not stay "mini".
How about defs-static or defs-init?  (And yes, I'm shying away
from renaming defs, that's just too big and churny a change for
such a slight misnomer.)

> The new file is designed to be idempotent w.r.t. mutiple inclusions,

s/designed/meant/, no?  I don't see a design document.  ;->

> and this will help us to cope better with e.g. generated tests and
> tests with complex setups, scaffoldings or indirections.

What is scaffoldings?  I think the first line of the summary text was
completely sufficient.

> * tests/defs.in: Removed, it's contents split among ...

its

> * tests/defs: ... this new file ...
> * tests/minidefs.in: ... and this new file.

You need to mention the remaining changes here; e.g., that defs sources
the other file now.

> * configure.ac (AC_CONFIG_FILES): Remove `tests/defs', add
> `tests/minidefs'.
> * configure.ac (AC_CONFIG_LINKS): Add `tests/defs'.
> * tests/Makefile.am ($(parallel_tests)): Update.
> ($(instspc_tests)): Likewise.
> * tests/.gitignore: Update.

OK with those changes.

Thanks,
Ralf