Re: [SIMPLE PATCH] {maint} Add test for `AM_WITH_DMALLOC' macro.

[Stefano Lattarini]

On Sunday 26 September 2010, Stefano Lattarini wrote:
> On Sunday 26 September 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Sun, Sep 26, 2010 at 09:51:11PM CEST:
> > > On Sunday 26 September 2010, Ralf Wildenhues wrote:
> > > > * Stefano Lattarini wrote on Tue, Sep 21, 2010 at 12:57:10PM CEST:
> > > > > +dnl Let's show some good practices ;-)
> > > > > +AC_SUBST([AM_LDFLAGS], [$LDFLAGS])
> > > > 
> > > > This is not needed, nor would I recommend it.  LDFLAGS is
> > > > AC_SUBSTed by Autoconf already, and used in link flags
> > > > already anyway.
> > > 
> > > You sure?  If I remove the AC_SUBST of LDFLAGS, the test fails
> > 
> > > with:
> > Well yes, you need to adjust the test to grep LDFLAGS, of course.
> 
> I did that, of course ;-)  But LDFLAGS is not AC_SUBT'd by default,
OK, it is apparently due to the fact that we don't have AC_PROG_CC in
configure.in.  Makes sense.

> leading to the failure I reported.  If I add "AC_SUBST([LDFLAGS])"
> to configure.in, the test passes.

So, ok to push with LDFLAGS AC_SUBST'd by hand?

Regards,
  Stefano