automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Overhauled and modularized tests in `instspc.test'.


From: Ralf Wildenhues
Subject: Re: [PATCH v2] Overhauled and modularized tests in `instspc.test'.
Date: Thu, 16 Sep 2010 21:57:49 +0200
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Thu, Sep 16, 2010 at 09:53:22PM CEST:
> On Thursday 16 September 2010, Ralf Wildenhues wrote:
> > With nits below addressed, the patch is OK for master, but please
> > commit to a new branch off of maint

> That's what I tried at first, but unfortunately the maint branch lacks
> support for silent-rules.  However, it might be possible that $(AM_V_GEN)
> and friends behaves as no-op in maint,

Yes you can assume that.

> > > --- a/tests/Makefile.am
> > > +++ b/tests/Makefile.am
> 
> > > +$(instspc_tests): Makefile.am
> > > + $(AM_V_at)rm -f $@ address@hidden
> > > + $(AM_V_GEN) :; \
> > > +   base=`expr x'$@' : x'instspc-\(.*\)\.test$$'`; \
> > 
> > I think $@ could contain $(srcdir) here, no?
> Why? In "True VPATH Spirit", we generate tests in the builddir, not in
> the srcdir.

Are they distributed?  If yes, then from a tarball, they are in srcdir.
(The user might have botched time stamps, or modified an input file on
purpose, say for a bugfix.)

Cheers,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]