[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Modernize, improve and/or extend test scripts `conf*.test'.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] Modernize, improve and/or extend test scripts `conf*.test'. |
Date: |
Wed, 8 Sep 2010 20:48:27 +0200 |
User-agent: |
Mutt/1.5.20 (2010-04-22) |
* Stefano Lattarini wrote on Wed, Sep 08, 2010 at 08:45:15PM CEST:
> On Wednesday 08 September 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Tue, Sep 07, 2010 at 12:19:02PM CEST:
> > > + echo ' ' $(DIST_COMMON) ' ' | grep '[ /]acconfig\.h '
> >
> > Just curious, but why not
> > echo ' $(DIST_COMMON) ' | ...
> >
> > and likewise in other tests?
> To be honest, I wasn't thinking about VPATH rewriting here; my idiom
> was to avoid the test to fail spuriously in case $(DIST_COMMONS)
> contains tabs instead of spaces.
Ah ok, I didn't think of that. Patch is better the way you posted it
then.
Thanks!
Ralf