Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted.

[Ralf Wildenhues]

Hi Stefano,

* Stefano Lattarini wrote on Fri, Sep 03, 2010 at 12:14:18AM CEST:
> * tests/defs.in ($srcdir): Define unconditionally to @address@hidden
> Remove code $srcdir normalization, which is now useless.

> --- a/tests/defs.in
> +++ b/tests/defs.in
> @@ -21,7 +21,7 @@
>  # Tom Tromey <address@hidden>
>  
>  # Absolutely necessary variable(s).
> -srcdir=${srcdir-'@abs_srcdir@'}
> +srcdir='@abs_srcdir@'

Can you explain why this is not needed conditionally any more?
I mean, was there a reason we didn't already do that last time?

Thanks,
Ralf

> @@ -234,18 +234,6 @@ do
>    esac
>  done
>  
> -
> -# Always use an absolute srcdir.  Otherwise symlinks made in subdirs
> -# of the test dir just won't work.
> -case "$srcdir" in
> - [\\/]* | ?:[\\/]*)
> -    ;;
> -
> - *)
> -    srcdir=`CDPATH=: && cd "$srcdir" && pwd`
> -    ;;
> -esac
> -