automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Improve and extend tests `asm*.test'.


From: Ralf Wildenhues
Subject: Re: [PATCH] Improve and extend tests `asm*.test'.
Date: Sun, 8 Aug 2010 13:09:03 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 02:19:20PM CEST:
> * tests/asm.test: Use configure.in stub generated by ./defs,
> and avoid obsoleted autoconf constructs.  Make grepping of
> Automake stderr stricter.  Do not create useless source file.
> Improve verbose messages.  Minor cosmetic changes.  Tell to
> keep it in sync with other sister tests asm*.test.
> * tests/asm2.test: Likewise.
> * tests/asm3.test: Likewise.

OK with nits below addressed.

Thanks,
Ralf

> --- a/tests/asm.test
> +++ b/tests/asm.test

> +echo '*** Run 1 -- Should fail because we need CC and CCAS ***'

s/Run/Try/ ?  s/Should/should/ ?

> +echo '*** Run 4 -- We have every needed, expect a success ***'

s/every/&thing/   several instances in the patch
s/ a / /

> --- a/tests/asm2.test
> +++ b/tests/asm2.test

>  AUTOMAKE_fails
> -grep AM_PROG_AS stderr
> +grep 'define .*am__fastdepCCAS.* add .*AM_PROG_AS' stderr

I prefer not grepping for internal details like am__fastdepCCAS.
More than one instance in the patch.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]