[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC] Refactoring maintainer checks (use perl, add whitelisting)
From: |
Ralf Wildenhues |
Subject: |
Re: [RFC] Refactoring maintainer checks (use perl, add whitelisting) |
Date: |
Mon, 26 Jul 2010 16:32:45 +0200 |
Hello Stefano,
* Stefano Lattarini wrote on Mon, Jul 26, 2010 at 01:58:08PM CEST:
> This patch substitutes (almost) all the sed/grep maintainer syntax checks
> in `Makefile.am' with a new perl script `maintcheck.pl'.
Why? Honest question. perl regex isn't necessarily more readable than
sed, in fact I find some of the constructs you introduced decidedly less
readable. Also, testing in the presence of VPATH builds is a
requirement.
I think a reorganization of maint checks, *if at all* done, should be
done unified to/across gnulib and coreutils' infrastructure, rather than
yet another reimplementation. I don't really see the need though, the
existing tests are not broken, are they?
Thanks,
Ralf