[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix bugs in test script silent5.test.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] Fix bugs in test script silent5.test. |
Date: |
Thu, 24 Jun 2010 20:29:23 +0200 |
User-agent: |
Mutt/1.5.20 (2010-04-22) |
Hi Stefano,
* Stefano Lattarini wrote on Wed, Jun 23, 2010 at 10:01:26PM CEST:
> This tiny patch fix a nasty bug in 'silent5.test' (due to the use of
> grep instead of egrep) that could have lead to false negatives.
>
> The bug was introduced in one of my previous patches ("Improved test
> silent5.test", de09b369b135b971bffb0efe383716237b9bf7f1). In hindsight,
> a somewhat ironic summary message...
Thanks, this needs to go into maint. Actually, I'm attaching it right
to the breaking commit and merging that to maint, with a short-lived
bugfix branch. When later browsing the history graph, this allows to
easily find nodes from which two or more children emerge: these are
either regressions or base points for new feature development. The two
situations are usually easily distinguished.
> From 6b78b3469c2f01e9a2a0746c2764a2eed96beb6f Mon Sep 17 00:00:00 2001
> From: Stefano Lattarini <address@hidden>
> Date: Wed, 23 Jun 2010 21:56:04 +0200
> Subject: [PATCH] Fix bugs in test script silent5.test.
>
> * tests/silent5.test: Fixed a nasty bug (due to the use of grep
> instead of egrep) that could have lead to false negatives.
s/lead/led/
Cheers,
Ralf