[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/2] Avoid another use of `chmod -R'.
From: |
Stefano Lattarini |
Subject: |
[PATCH 1/2] Avoid another use of `chmod -R'. |
Date: |
Tue, 30 Mar 2010 17:52:21 +0200 |
User-agent: |
KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.2; i686; ; ) |
* Makefile.am (path-check): To be safe, do not use `chmod -R' on
$(distdir) before removing it (as Solaris `chmod -R' touches
symlink targets). Instead, use the cleanup strategy used in
distdir.am (which is also employed in tests/defs.in).
---
From 495193ac159fb973ad22b883091673ab340dc39e Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Tue, 30 Mar 2010 17:12:27 +0200
Subject: [PATCH 1/2] Avoid another use of `chmod -R'.
* Makefile.am (path-check): To be safe, do not use `chmod -R' on
$(distdir) before removing it (as Solaris `chmod -R' touches
symlink targets). Instead, use the cleanup strategy used in
distdir.am (which is also employed in tests/defs.in).
---
ChangeLog | 9 +++++++++
Makefile.am | 3 ++-
Makefile.in | 3 ++-
3 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index be5dbae..69c811b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2010-03-30 Stefano Lattarini <address@hidden>
+
+ Avoid another use of `chmod -R'.
+
+ * Makefile.am (path-check): To be safe, do not use `chmod -R' on
+ $(distdir) before removing it (as Solaris `chmod -R' touches
+ symlink targets). Instead, use the cleanup strategy used in
+ distdir.am.
+
2010-03-28 Ralf Wildenhues <address@hidden>
Remove uses of @acronym and @sc.
diff --git a/Makefile.am b/Makefile.am
index 08047d2..86fb240 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -535,7 +535,8 @@ path-check: distdir
## of files on stdin, at least.
find . -print | xargs pathchk -p); \
status=$$?; \
- chmod -R a+w $(distdir) > /dev/null 2>&1; rm -rf $(distdir); \
+ find $(distdir) -type d '!' -perm -200 -exec chmod u+w {} ';'; \
+ rm -rf $(distdir); \
exit $$status
## Program to use to fetch files.
diff --git a/Makefile.in b/Makefile.in
index 6a96eb4..f146ce9 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -1246,7 +1246,8 @@ path-check: distdir
(cd $(distdir) && \
find . -print | xargs pathchk -p); \
status=$$?; \
- chmod -R a+w $(distdir) > /dev/null 2>&1; rm -rf $(distdir); \
+ find $(distdir) -type d '!' -perm -200 -exec chmod u+w {} ';'; \
+ rm -rf $(distdir); \
exit $$status
fetch:
--
1.6.5
[PATCH 2/2] Avoid an unportable use of `$status' shell variable., Stefano Lattarini, 2010/03/30
Re: A couple of patches w.r.t. the target `path-check', Ralf Wildenhues, 2010/03/30