Re: [PATCH 1/3] quotes in configure.ac

[William Pursell]

Ralf Wildenhues wrote:

> > @@ -2886,8 +2889,9 @@ If a Lex source file is seen, then this macro must be 
> > used.
> >  Autoconf Manual}.
> >
> >  @item AC_REQUIRE_AUX_FILE
> > address@hidden will ensure each file for which this macro is
> > -called exists in the aux directory, and will complain otherwise.  It
> > address@hidden will look in the aux directory
> > +for each file on which this macro is invoked and will complain if
> > +the file does not exist.  It
>
> How about this instead:
>   For each @code{AC_REQUIRE_AUX_FILE(address@hidden@var{file}}])},
>   @command{automake} will ensure that @address@hidden exists in the
>   aux directory, and will complain otherwise.

That reads well.

> > @@ -2900,8 +2904,10 @@ generated @file{Makefile.in}, unless 
> > @code{AM_SUBST_NOTMAKE} is also
> >  used for this variable.  @xref{Setting Output Variables, , Setting
> >  Output Variables, autoconf, The Autoconf Manual}.
> >
> > +Several macros invoke @code{AC_SUBST} and cause certain
> > +variables to be defined in each generated Makefile.in.
>
> Hmm, I'm not too fond of this sentence.  I don't really see what value
> it adds over the following sentence.  Can you describe what information
> you find lacking in the original text, maybe we can find a better way
> then?

When I was reading through the page, it just felt
like something was missing there.  At first, I thought
"If the Autoconf manual..." was a typo that should have
read "In the Auto...", and it took me a while to realize
what the paragraph is talking about.  It seems like there
needs to be something introducing the idea that it's
talking about other macros invoking AC_SUBST.

> The third patch looks ok, except for one question:
> > address@hidden AM_SUBST_NOTMAKE(@var{var})
> > address@hidden AM_SUBST_NOTMAKE(@ovar{var})
>
> Why this change?  AM_SUBST_NOTMAKE currently supports having no
> arguments, or an empty argument, but I don't see any value in allowing
> users to use that.  What would be the gain?

That's my mistake  I've gotten overly zealous about
quoting in m4 macros and mistook the brackets, not realizing
they were indicating optional arguments.


--
William Pursell