automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

No uniquifying for fatal, prog_error, and verbose messages.


From: Ralf Wildenhues
Subject: No uniquifying for fatal, prog_error, and verbose messages.
Date: Sun, 26 Oct 2008 16:49:22 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

This is just a small bit that I observed when looking into threaded
automake: uniquified messages are not useful for --verbose (au
contraire, that can be quite mystifying ;-), neither for messages
that cause fatal errors or even backtraces from perl.

Pushed to master.

Cheers,
Ralf

2008-10-26  Ralf Wildenhues  <address@hidden>

        No uniquifying for fatal, prog_error, and verbose messages.
        There is no point in dropping critical messages, even if they
        are duplicates (unlikely to happen unless they have been sent
        as non-critical messages before), and verbose messages should
        enable to show progress, even using duplicate statements.
        * lib/Automake/ChannelDefs.pm (fatal, automake, verb): Set
        `uniq_part' to `UP_NONE' when registering these channels.

diff --git a/lib/Automake/ChannelDefs.pm b/lib/Automake/ChannelDefs.pm
index 898b1ea..eff5d52 100644
--- a/lib/Automake/ChannelDefs.pm
+++ b/lib/Automake/ChannelDefs.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2002, 2003, 2006 Free Software Foundation, Inc.
+# Copyright (C) 2002, 2003, 2006, 2008 Free Software Foundation, Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -129,7 +129,7 @@ Informative messages.
 # Do not forget to update &usage and the manual
 # if you add or change a warning channel.
 
-register_channel 'fatal', type => 'fatal';
+register_channel 'fatal', type => 'fatal', uniq_part => UP_NONE;
 register_channel 'error', type => 'error';
 register_channel 'error-gnu', type => 'error';
 register_channel 'error-gnu/warn', type => 'error';
@@ -138,7 +138,8 @@ register_channel 'automake', type => 'fatal', backtrace => 
1,
   header => ("####################\n" .
             "## Internal Error ##\n" .
             "####################\n"),
-  footer => "\nPlease contact <address@hidden>.";
+  footer => "\nPlease contact <address@hidden>.",
+  uniq_part => UP_NONE;
 
 register_channel 'gnu', type => 'warning';
 register_channel 'obsolete', type => 'warning', silent => 1;
@@ -147,7 +148,7 @@ register_channel 'portability', type => 'warning', silent 
=> 1;
 register_channel 'syntax', type => 'warning';
 register_channel 'unsupported', type => 'warning';
 
-register_channel 'verb', type => 'debug', silent => 1;
+register_channel 'verb', type => 'debug', silent => 1, uniq_part => UP_NONE;
 register_channel 'note', type => 'debug', silent => 0;
 
 =head2 FUNCTIONS




reply via email to

[Prev in Thread] Current Thread [Next in Thread]