automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: automake (GNU automake) 1.10.1 9 of 538 tests failed


From: Ralf Wildenhues
Subject: Re: automake (GNU automake) 1.10.1 9 of 538 tests failed
Date: Sun, 5 Oct 2008 21:54:48 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

[ moving from bug-automake ]

* Ralf Wildenhues wrote on Mon, Sep 29, 2008 at 09:30:28PM CEST:
> 
> The depcomp6.test one looks like bad interaction between AC_PROG_CC_C_O
> and AM_PROG_CC_C_O, or a shell bug: although the compiler is deemed
> potent by the former, the latter still rewrited $CC to prepend the
> 'compile' script:

I'm still stumped by the fact that sh on AIX evaluates these lines
wrongly, and haven't gotten down to the bottom of this shell bug.

Reproduced it though, thus pushed the patch below, including a NEWS
entry, to master and branch-1-10.

Cheers,
Ralf

> 2008-09-29  Ralf Wildenhues  <address@hidden>
> 
>       * m4/minuso.m4 (AM_PROG_CC_C_O): Work around shell quoting issue
>       with AIX sh; fixes depcomp6.test failure.
        * NEWS, THANKS: Update.
>       Report by Rainer Tammer.


diff --git a/NEWS b/NEWS
index ee84444..1a14ec6 100644
--- a/NEWS
+++ b/NEWS
@@ -106,6 +106,9 @@ Bugs fixed in 1.10a:
 
   - Fix aix dependency tracking for libtool objects.
 
+  - Work around AIX sh quoting issue in AC_PROG_CC_C_O, leading to
+    unnecessary use of the `compile' script.
+
   - For nobase_*_LTLIBRARIES with nonempty directory components, the
     correct `-rpath' argument is used now.
 
> diff --git a/m4/minuso.m4 b/m4/minuso.m4
> index 925baec..d8b1620 100644
> --- a/m4/minuso.m4
> +++ b/m4/minuso.m4
> @@ -1,12 +1,12 @@
>  ##                                                          -*- Autoconf -*-
> -# Copyright (C) 1999, 2000, 2001, 2003, 2004, 2005
> +# Copyright (C) 1999, 2000, 2001, 2003, 2004, 2005, 2008
>  # Free Software Foundation, Inc.
>  #
>  # This file is free software; the Free Software Foundation
>  # gives unlimited permission to copy and/or distribute it,
>  # with or without modifications, as long as this notice is preserved.
>  
> -# serial 5
> +# serial 6
>  
>  # AM_PROG_CC_C_O
>  # --------------
> @@ -18,8 +18,9 @@ AC_REQUIRE_AUX_FILE([compile])dnl
>  # FIXME: we rely on the cache variable name because
>  # there is no other way.
>  set dummy $CC
> -ac_cc=`echo $[2] | sed ['s/[^a-zA-Z0-9_]/_/g;s/^[0-9]/_/']`
> -if eval "test \"`echo '$ac_cv_prog_cc_'${ac_cc}_c_o`\" != yes"; then
> +am_cc=`echo $[2] | sed ['s/[^a-zA-Z0-9_]/_/g;s/^[0-9]/_/']`
> +eval am_t=\$ac_cv_prog_cc_${am_cc}_c_o
> +if test "$am_t" != yes; then
>     # Losing compiler, so override with the script.
>     # FIXME: It is wrong to rewrite CC.
>     # But if we don't then we get into trouble of one sort or another.
> 
> 
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]