automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: automake/500: unnecessary -I options in DEFAULT_INCLUDES (make clutt


From: Stepan Kasal
Subject: Re: automake/500: unnecessary -I options in DEFAULT_INCLUDES (make clutter)
Date: Wed, 30 Aug 2006 20:20:48 +0200
User-agent: Mutt/1.4.2.1i

Hello,

On Wed, Aug 30, 2006 at 09:55:49AM -0700, Paul Eggert wrote:
>    gcc -std=gnu99  -I. -I. -I.       -c base64.c
> 
> to this:
> 
>    gcc -std=gnu99  -I.       -c base64.c
> 
> I'd also like to remove those unnecessary and distracting spaces, but
> that's for a later patch.

how do you plan to remove the spaces?  Do you plan to write something
like $(DEFS)$(DEFAULT_INCLUDES)$(INCLUDES)$(AM_CPPFLAGS) and try to
ensure that each of the variables, if nonempty, starts with a space?
That would make the makefile ugly.

I heard there are filters which can do fancy thinks with the make
output; they were often recommended to people requesting less
verbose output.

I believe these filters are an adequate tool if you want to eliminate
extra spaces and duplicate -I options.

I recognize there is slight difference: the wrapper changes what you
see, but the compiler still gets the option multiple times.  But I
think it is reasonable to suppose that it won't affect the function
of the compiler.

I understand the need for prettier compile commands, and I appreciate
the effort.  But if the prettier ``surface'' means the inner coding
becomes more cryptic, it's not worth it, IMHO.

Stepan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]