automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: white space changes in mkinstalldirs and depcomp


From: Alexandre Duret-Lutz
Subject: Re: FYI: white space changes in mkinstalldirs and depcomp
Date: Sun, 10 Aug 2003 00:54:27 +0200
User-agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux)

>>> "Jim" == Jim Meyering <address@hidden> writes:

 Jim> I've just checked in the following changes on the 1.7 branch
 Jim> (thinking it was the trunk -- hope that's ok).

The depcomp change is not a problem, but I'd rather not make any
gratuitous change to mkinstalldirs on the branch.  The reason is
that both automake and gettextize will install mkinstalldirs in
a package, and when the installed files are not identical users
complain about spurious CVS diff each time they reconfigure their
package (yes, this has happened).

Also you have added your ChangeLog entry in _two_ different places.
See
http://sources.redhat.com/cgi-bin/cvsweb.cgi/automake/ChangeLog.diff?r1=1.2024.2.195&r2=1.2024.2.196&cvsroot=automake

 Jim> # That's a space and a tab in the [].
 Jim> -      sed -e 's,^.*\.[a-z]*:[    ]*,,' -e 's,$,:,' < "$tmpdepfile" >> 
"$depfile"
 Jim> +      sed -e 's,^.*\.[a-z]*:[     ]*,,' -e 's,$,:,' < "$tmpdepfile" >> 
"$depfile"

Too bad your whitespace filter doesn't also edit the comments :)
-- 
Alexandre Duret-Lutz





reply via email to

[Prev in Thread] Current Thread [Next in Thread]