automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 02-distclean-test.diff


From: Alexandre Duret-Lutz
Subject: Re: 02-distclean-test.diff
Date: Fri, 27 Jun 2003 01:20:57 +0200
User-agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux)

>>> "Derek" == Derek Robert Price <address@hidden> writes:

[...]

 Derek> I also implemented my idea about keeping track of $where
 Derek> for each AC_CONFIG_LINKS call.  Anyhow, everything works
 Derek> now and no new tests are broken.  If the guys who admin
 Derek> sources.redhat.com ever fix my account, I can commit it,
 Derek> with your approval.

Don't desperate, give them at least one week.

I'm happy with the implementation of the patch, but since this
is a new feature there are two more things that I'd like to see
committed at the same time: a mention in ./NEWS, and another one
in the manual (at least in the "Other things Automake
recognizes" section).  Consider that virtual augmented patch
approved.

 Derek> * automake.in (scan_autoconf_traces): Handle AC_CONFIG_LINKS.
 Derek> (handle_configure): Handle adding AC_CONFIG_LINKS arguments to
 Derek> distclean targets (CONFIG_CLEAN_FILES makefile var).
 Derek> * tests/Makefile.am (XFAIL_TESTS): Add new tests.

I hope not :)

 Derek> (TESTS): Ditto.
 Derek> * tests/distclean.test: New test that links are cleaned on distclean.
 Derek> * tests/distlinksource.test: New test that source files for links are
 Derek> distributed.

Since these are both checking the support for AC_CONFIG_LINK,
how about renaming them to something like conflnk.test and
conflnk2.test?  That will leave room for future tests about
the same feature without hurting DJGPP with long filenames.
-- 
Alexandre Duret-Lutz





reply via email to

[Prev in Thread] Current Thread [Next in Thread]