[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: install-sh clean-up
From: |
Alexandre Duret-Lutz |
Subject: |
Re: install-sh clean-up |
Date: |
Thu, 16 Jan 2003 23:42:10 +0100 |
User-agent: |
Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.2 (i386-pc-linux-gnu) |
| 2003-01-14 Jim Meyering <address@hidden>
|
| Accept --help and --version, and lots of syntactic clean-up.
This looks great!
[...]
| + # Waiting for this to be detected by the "$instcmd $src $dsttmp" command
| + # might cause directories to be created, which would be especially bad
| + # if $src (and thus $dsttmp) contains '*'.
| + if test -f "$src" || test -d "$src"; then :; else
| + echo "$0: $src does not exist." >&2
| + exit 1
| + fi
Since you are removing useless `else :' maybe this could also
be shortened to
if test ! -f "$src" && test ! -d "$src"; then
echo "$0: $src does not exist." >&2
exit 1
fi
[...]
| + # If destination is a directory, append the input filename; won't work
| + # if double slashes aren't ignore.
ignored
[...]
--
Alexandre Duret-Lutz