automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: support for partial messages (i.e. chained diagnostics)


From: Akim Demaille
Subject: Re: FYI: support for partial messages (i.e. chained diagnostics)
Date: 08 Oct 2002 09:01:30 +0200
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Honest Recruiter)

| There are many place in Automake where I've output messages
| in two parts.  For instance:
| 
|   msg 'channel', 'foo:2', 'redefinition of A ...';
|   msg 'channel', 'foo:1', '... A previously defined here';
| 
| This isn't perfect because if we latter do
| 
|   msg 'channel', 'foo:3', 'redefinition of A ...';
|   msg 'channel', 'foo:1', '... A previously defined here';
| 
| then `foo:1: ... A previously defined here' will be filtered out
| as a duplicate message.
| 
| The following patch adds a way to link associated messages
| together:
| 
|   msg 'channel', 'foo:2', 'redefinition of A ...', partial => 1;
|   msg 'channel', 'foo:1', '... A previously defined here';
| 
| and the filtering will apply as if the two lines were one single message.

I like the idea!  But I have a suggestion (maybe this suggestion is
wrong, and don't feel obliged to answer): how about having `msg' and
the like return an object message, and have a means to extend a
message object?

my $msg = new msg;
$msg->msg 'channel', 'foo:3', 'redefinition of A ...';
$msg->msg 'channel', 'foo:1', '... A previously defined here';

Which would be equivalent to (but nicer than):

my $msg = msg 'channel', 'foo:3', 'redefinition of A ...';
$msg->msg 'channel', 'foo:1', '... A previously defined here';

This would avoid the local $partial, make it possible to grow several
different messages at the same time (but I confess I don't know if
that's useful).




reply via email to

[Prev in Thread] Current Thread [Next in Thread]