Re: RFC: diagnose target clashes (for PR/344)

[Richard Boulton]

On Tue, 2002-09-10 at 23:57, Alexandre Duret-Lutz wrote:
> I'd really appreciate comments on the following patch.
It looks good to me, at a cursory examination.

>   1. &file_contents_internal used to contain a hack to define
>      rules only for the set of conditions where they haven't
>      been defined already.  So &rule_define was not called when
>      the rule was already defined (making clash detection from
>      &rule_define somewhat hard...).  I have moved this hack
>      into &rule_define.
> 
>      Richard, since you wrote this code it would be nice if you
>      could review the rational I've added in a comment, in case
>      I missed the real intent.
Your comment looks correct.  (Although it's been a while since I wrote
the original, so I'm relying more on checking the logic than remembering
the intent.)

-- 
Richard