automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Patch: FYI: fixlet in maintainer-check


From: Tom Tromey
Subject: Patch: FYI: fixlet in maintainer-check
Date: 27 Jul 2002 14:50:52 -0600

I'm checking this in on the branch.

This is just a temporary hack to a maintenance target to work around
an oddity in the version of bash I'm using.  On this box, even with
LANG=C, `echo [a-z]*.am' will match files whose names start with
upper-case letters.  I suspect this isn't, unfortunately, a bug :-(

Tom

Index: ChangeLog
from  Tom Tromey  <address@hidden>
        Released Automake 1.4-p6.

        * Makefile.am (maintainer-check): Use [:lower:] instead of [a-z].

        * configure.in: Updated to automake 1.4-p6.
Index: Makefile.am
===================================================================
RCS file: /cvs/automake/automake/Makefile.am,v
retrieving revision 1.126.4.4
diff -u -r1.126.4.4 Makefile.am
--- Makefile.am 14 Jul 2002 17:38:55 -0000 1.126.4.4
+++ Makefile.am 27 Jul 2002 20:45:40 -0000
@@ -95,12 +95,12 @@
 ## expect no instances of '${...}'.  However, $${...} is ok, since that
 ## is a shell construct, not a Makefile construct.
 ## The backslash in `$${' is needed for some versions of bash.
-       @if test `fgrep '\$${' $(srcdir)/[a-z]*.am | fgrep -v '$$$$' | wc -l` 
-ne 0; then \
+       @if test `fgrep '\$${' $(srcdir)/[:lower:]*.am | fgrep -v '$$$$' | wc 
-l` -ne 0; then \
          echo "found too many uses of '\$${'" 1>&2; \
          exit 1;                               \
        else :; fi
 ## Make sure all invocations of mkinstalldirs are correct.
-       @if test `fgrep 'mkinstalldirs' $(srcdir)/[a-z]*.am | fgrep -v 
'$$(mkinstalldirs)' | wc -l` -ne 0; then \
+       @if test `fgrep 'mkinstalldirs' $(srcdir)/[:lower:]*.am | fgrep -v 
'$$(mkinstalldirs)' | wc -l` -ne 0; then \
          echo "found incorrect use of mkinstalldirs" 1>&2; \
          exit 1; \
        else :; fi



reply via email to

[Prev in Thread] Current Thread [Next in Thread]