Re: [PATCH] Update of my February patches to CVS automake

[Alexandre Duret-Lutz]

Hi,

Ok, let's start with this.

| This patch does these things:

Could you submit separate patches for each of them?  It will be
easier to review, discuss, and commit. (Or are the earlier
versions you submitted still up-to-date?)

Here are some comments.

| * add PDF support via texi2dvi's --pdf option.  Triggered by `make pdf'

Maybe I missed something, but this part seems incomplete.
TEXI2PDF is defined but not used.  I guess you should add some
info->pdf rule to lib/am/texibuild.am.

| * test for --help and --version in gnits mode

I think this will fail for most programs, because it assumes
this is ok to run programs from the build tree.  Many programs
needs special setup to be run before installation (for instance
with Automake you would have to fiddle with the `perllibdir'
envvar).

Maybe this kind of check should only be done by `installcheck'
(if done at all).

| * better checks for distribution of license files
| ** prefer COPYING.LESSER to COPYING.LIB (error in gnits mode, warning in
|    gnu mode), 

This sounds highly debatable to me.  Is that the job of Automake
to force users to upgrade their package license?  Besides, the
GNU Coding Standard still recommands `COPYING.LIB'.

|               distribute COPYING.LESSER automatically
| ** in gnu or gnits modes, don't require COPYING if COPYING.LESSER is there

I'd say "if either COPYING.LESSER or COPYING.LIB is used".

| 
| * support for shtool

I've not looked at this.

| I can sign a copyright assignment if it's accepted.  The code was
| already more or less revised when I submitted patches relative to
| Automake 1.5 back in February; this is against CVS automake, checked
| out about two hours ago (2PM in Europe).
| 
| Here is the ChangeLog entry.

For this kind of changes you should update NEWS too.

[...]

-- 
Alexandre Duret-Lutz