automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ansi5.test fix


From: Tom Tromey
Subject: Re: ansi5.test fix
Date: 23 Mar 2002 21:40:52 -0700

>>>>> "adl" == Alexandre Duret-Lutz <address@hidden> writes:

adl> I'd like an approval (or disapproval) for this patch.
adl> ansi5.test fails on SunOS because it runs
adl>   $MAKE U=_
adl> but make does not propagate the U=_ setting to sub-makes.

I think anything that works is ok.  Maybe that's a bad attitude, given
the propensity of our tests to fail in strange environments.

adl> I think using 
adl>    U=_ $MAKE -e
adl> would be better, but I'm wondering if there are some
adl> drawbacks with using -e.

I don't know.

adl> The patch below updates maintainer-check to detect occurrences of
adl> "$MAKE foo=bar" and suggest "foo=bar $MAKE -e".

This only matters if we have subdirs, right?

Anyway, I don't have a real problem with this.
It might be more reliable to simply sed `U = _' into the Makefiles.
But I'm not too concerned about it.

Tom



reply via email to

[Prev in Thread] Current Thread [Next in Thread]