automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

AR is not defined in Makefile.in for convenience libraries


From: Alexandre Duret-Lutz
Subject: AR is not defined in Makefile.in for convenience libraries
Date: 28 Jun 2001 12:02:39 +0200
User-agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7

Hi,

I've just discovered that 1.4g does not define AR when building
a convenience library.  Actually it still works for me because
GNU make presets AR, but since older versions of Automake used
to define this variable and that 1.4g looks like it is trying to
do that too, I believe it's a bug.

As I understand it, AR ought to be set by lib/am/libs.am which
reads:

[...]
if %?FIRST%
AR = ar
RANLIB = @RANLIB@
endif %?FIRST%
[...]

FIRST is tied to $first in am_install_var as follow

[...]
        $output_rules .= &file_contents ($file,
                                         ('FIRST' => $first,
[...]

But $first is either set to 0 or the empty string (both are
false values).  I think this first assignment should be 1.

Note that with the following patch I now get two `RANLIB =
@RANLIB@' definitions: one from the detection of AC_PROG_RANLIB,
and another one from lib/am/libs.am.  I'm not sure which one you
want to remove (if any).

Index: ChangeLog
from  Alexandre Duret-Lutz  <address@hidden>

        * automake.in (am_install_var): Assign 1 to $first on
        first interation.

Index: automake.in
===================================================================
RCS file: /cvs/automake/automake/automake.in,v
retrieving revision 1.1142
diff -u -r1.1142 automake.in
--- automake.in 2001/06/24 03:38:25     1.1142
+++ automake.in 2001/06/28 09:44:59
@@ -7170,7 +7170,7 @@
 
     # True if the iteration is the first one.  Used for instance to
     # output parts of the associated file only once.
-    my $first = 0;
+    my $first = 1;
     foreach my $X (sort keys %valid)
     {
        my $one_name = $X . '_' . $primary;
@@ -7304,7 +7304,7 @@
                                          'INSTALL' => $install_p,
                                          'DIST'    => $dist_p));
 
-       $first = '';
+       $first = 0;
     }
 
     # The JAVA variable is used as the name of the Java interpreter.

-- 
Alexandre Duret-Lutz





reply via email to

[Prev in Thread] Current Thread [Next in Thread]