[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Automake-NG] [FYI] [ng] refactor: remove all uses of '$(am__strip_d
From: |
Akim Demaille |
Subject: |
Re: [Automake-NG] [FYI] [ng] refactor: remove all uses of '$(am__strip_dir)' |
Date: |
Fri, 31 Aug 2012 13:25:28 +0200 |
Hi!
Le 8 août 2012 à 12:40, Stefano Lattarini a écrit :
> On 08/08/2012 12:36 PM, Stefano Lattarini wrote:
>> Prefer using GNU make built-in '$(notdir)' instead. This change doesn't
>> offer any serious simplification, but is just a step in the general
>> direction of moving more non-trivial processing to GNU make.
>>
>> * lib/am/lib.am: Rewritten some install/uninstall rules to avoid
>> using '$(am__strip_dir)'.
>> * lib/am/lisp.am: Likewise.
>> * lib/am/ltlib.am: Likewise.
>> * lib/am/python.am: Likewise.
>> * lib/am/texinfos.am: Likewise.
>> * lib/am/header-vars.mk (am__strip_dir): Remove.
Nice!
> And consider this squashed in:
>
> diff --git a/lib/am/python.am b/lib/am/python.am
> index d4b6626..c99d42c 100644
> --- a/lib/am/python.am
> +++ b/lib/am/python.am
> @@ -26,7 +26,8 @@ am__installdirs += "$(DESTDIR)$(%NDIR%dir)"
> ?!EXEC?.PHONY install-data-am: install-%DIR%PYTHON
> install-%DIR%PYTHON: $(%DIR%_PYTHON)
> @$(NORMAL_INSTALL)
> - @$(if $(%DIR%_PYTHON),$(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)")
> + @$(if $(and $(%NDIR%dir),$(%DIR%_PYTHON)),$(strip \
> + )$(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)")
I don't understand the 'strip' part.
> if %?BASE%
> @test -n "$(%NDIR%dir)" && test -n "$(%DIR%_PYTHON)" || exit 0; \
> dlist='$(notdir $(%DIR%_PYTHON))'; \
>
> Now the whole testsuite correctly passes.
>
> Thanks,
> Stefano
>