[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: AT_TESTED: make it work with full paths from AC_PATH_PROG
From: |
Allan Clark |
Subject: |
Re: AT_TESTED: make it work with full paths from AC_PATH_PROG |
Date: |
Tue, 17 Nov 2009 14:21:43 +0000 |
On Tue, Nov 17, 2009 at 13:01, Eric Blake <address@hidden> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> According to Allan Clark on 11/17/2009 3:30 AM:
> > Hi;
> >
> > in Autoconf-2.64, AT_TESTED() only works with utilities that would be
> found
> > with AC_CHECK_PROGS(). Full pathnames don't work, so tools such as
> > AC_PATH_PROGS() that report a full pathname cannot be AT_TESTED().
> >
> > The following patch should resolve this -- really all it does is preface
> a
> > "/" into the path tested, so that (ie AT_TESTED(@BZCAT@) where BZCAT is
> > /usr/bin/bzcat) the path "/" is tested, checking ///usr/bin/bzcat, before
> > testing /bin, checking /bin/usr/bin/bzcat.
>
> Nice idea. However, it adds the potential for false positives. A better
> patch would be to check for an absolute name prior to starting the loop
> over PATH. I'll work up a patch along those lines.
>
Cool.
What kind of false-positives? Are you concerned in matching a file /bzcat,
or /awk in the root directory? Worried about straying off the beaten $PATH?
I'm curious to see what you're thinking for my own benefit.
Thanks!
Allan
--
address@hidden "金鱼" http://linkedin.com/in/goldfish
Sent from London, Eng, United Kingdom