[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: carriage return line endings vs. literal ^M in status.m4
From: |
Ralf Wildenhues |
Subject: |
Re: carriage return line endings vs. literal ^M in status.m4 |
Date: |
Sun, 6 Apr 2008 00:12:09 +0200 |
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
<http://thread.gmane.org/gmane.comp.sysutils.autoconf.patches/5475/focus=5501>
Hello Elbert, Jim,
thanks for the feedback.
* Jim Meyering wrote on Sat, Apr 05, 2008 at 11:39:15PM CEST:
> Elbert replied privately:
>
> Think you made it working for os/2
> I send logs also...
The logs show a few minor issues:
First, your site file u:/moztools/config.site-gcc335b4 seems to have a
few portability issues:
| type: No such file or directory
| type: No such file or directory
| type: No such file or directory
| type: No such file or directory
| function: No such file or directory
| builtin: No such file or directory
Then, your hostname program looks broken:
| hostname: memory exhausted
Then, the gnulib macro gl_DOUBLE_SLASH_ROOT lacks a bit of quoting:
| checking whether // is distinct from /... ls: //: No such file or directory
| test: =: argument expected
| yes
The patch below, against gnulib, should fix this. OK to apply?
Finally, the code to set $MAN in coreutils/configure.ac leaves CR
instances in the variable:
| MAN='uname.1^M chroot.1^M hostid.1^M nice.1^M who.1^M ...'
Not sure whether that may be a problem later, probably not.
Cheers,
Ralf
2008-04-06 Ralf Wildenhues <address@hidden>
* m4/double-slash-root.m4 (gl_DOUBLE_SLASH_ROOT): Fix quoting,
hide error from 'ls', needed on OS/2.
Report by Elbert Pol <address@hidden>.
diff --git a/m4/double-slash-root.m4 b/m4/double-slash-root.m4
index 69d60d0..23bf5b0 100644
--- a/m4/double-slash-root.m4
+++ b/m4/double-slash-root.m4
@@ -1,5 +1,5 @@
-# double-slash-root.m4 serial 2 -*- Autoconf -*-
-dnl Copyright (C) 2006 Free Software Foundation, Inc.
+# double-slash-root.m4 serial 3 -*- Autoconf -*-
+dnl Copyright (C) 2006, 2008 Free Software Foundation, Inc.
dnl This file is free software; the Free Software Foundation
dnl gives unlimited permission to copy and/or distribute it,
dnl with or without modifications, as long as this notice is preserved.
@@ -24,8 +24,8 @@ AC_DEFUN([gl_DOUBLE_SLASH_ROOT],
gl_cv_double_slash_root='unknown, assuming no' ;;
esac
else
- set x `ls -di / //`
- if test $[2] = $[4] && wc //dev/null >/dev/null 2>&1; then
+ set x `ls -di / // 2>/dev/null`
+ if test "$[2]" = "$[4]" && wc //dev/null >/dev/null 2>&1; then
gl_cv_double_slash_root=no
else
gl_cv_double_slash_root=yes
- Re: carriage return line endings vs. literal ^M in status.m4, (continued)
- Re: carriage return line endings vs. literal ^M in status.m4, Jim Meyering, 2008/04/05
- Re: carriage return line endings vs. literal ^M in status.m4, Ralf Wildenhues, 2008/04/05
- Re: carriage return line endings vs. literal ^M in status.m4, Jim Meyering, 2008/04/05
- Re: carriage return line endings vs. literal ^M in status.m4, Ralf Wildenhues, 2008/04/05
- Re: carriage return line endings vs. literal ^M in status.m4, Jim Meyering, 2008/04/05
- Re: carriage return line endings vs. literal ^M in status.m4, Eric Blake, 2008/04/05
- Re: carriage return line endings vs. literal ^M in status.m4, Jim Meyering, 2008/04/05
- Re: carriage return line endings vs. literal ^M in status.m4,
Ralf Wildenhues <=
- Re: carriage return line endings vs. literal ^M in status.m4, Elbert Pol, 2008/04/06
- Re: carriage return line endings vs. literal ^M in status.m4, Ralf Wildenhues, 2008/04/05
- Re: carriage return line endings vs. literal ^M in status.m4, Jim Meyering, 2008/04/05
- Re: carriage return line endings vs. literal ^M in status.m4, Eric Blake, 2008/04/05
- Re: carriage return line endings vs. literal ^M in status.m4, Eric Blake, 2008/04/05
Re: Re: carriage return line endings vs. literal ^M in status.m4, ziedar, 2008/04/06