[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: a couple of patches to deal with w32 semantics
From: |
Ralf Wildenhues |
Subject: |
Re: a couple of patches to deal with w32 semantics |
Date: |
Tue, 4 Mar 2008 23:53:19 +0100 |
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
* Eric Blake wrote on Tue, Mar 04, 2008 at 10:58:16PM CET:
> Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de> writes:
>
> > here are two more patches for w32. [...]
> > OK to apply?
>
> Bah - I posted and committed a similar patch before I read this.
No worries, your patch was better anyway.
> > +# If making a directory and moving files from there to . succeeds, we
> > +# are probably on cygwin.
>
> Not just cygwin, but windows in general. And not just moving files into a
> read-
> only directory, but deleting files from there as well. Isn't it scary that
> Windows thinks everyone deserves root-like privileges?
Yep. Note that somehow the MSYS runtime seemed to avoid this trap,
though.
> > On MinGW, substitution of CR and 0xFF fails.
> >
> > * tests/torture.at (Substitute and define special characters):
> > MinGW awk cannot handle 0xFF, and on MinGW, the test does the
> > wrong thing for CR.
>
> I can't speak for this one (I avoid mingw as much as possible, only cross-
> compiling there), but it looks reasonable. Please apply.
Done, thanks!
Cheers,
Ralf