[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: CVS autoconf testsuite spurious messages
From: |
Akim Demaille |
Subject: |
Re: CVS autoconf testsuite spurious messages |
Date: |
Fri, 20 Jun 2003 09:54:04 +0200 |
User-agent: |
Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux) |
> Hi,
> I just tested CVS autoconf on my Tru64 unix workstation and noticed a
> spurious message during testsuite run :
> [...]
> ## ------------------------------ ##
> ## GNU Autoconf 2.57a test suite. ##
> ## ------------------------------ ##
> Executables (autoheader, autoupdate...).
> 1: tools.at:47 ok (skipped near `tools.at:71')
> sed: Cannot find or open file
> /home/njoly/temp/autoconf/tests/testsuite.dir/at-times.
> 2: tools.at:92 ok
> 3: tools.at:118 ok
> [...]
> This message exists for systems/shells that not implement `times'
> command (at least Tru64 5.1 and NetBSD 1.6.1). Autoconf 2.57 was
> protected, but it seems that it was removed in current CVS version.
> Here follow a small patch to restore the expected behaviour :
> Index: lib/autotest/general.m4
> ===================================================================
> RCS file: /cvs/autoconf/lib/autotest/general.m4,v
> retrieving revision 1.145
> diff -u -r1.145 general.m4
> --- lib/autotest/general.m4 12 Jun 2003 11:03:56 -0000 1.145
> +++ lib/autotest/general.m4 18 Jun 2003 11:34:28 -0000
> @@ -675,7 +675,8 @@
> # We're not including the group log, so the success message is
> written
> # in the global log separately. But we also write to the group
> log in
> # case they're using -d.
> - at_log_msg="$at_log_msg (`sed 1d $at_times_file`)"
> + test -f $at_times_file &&
> + at_log_msg="$at_log_msg (`sed 1d $at_times_file`)"
> echo "$at_log_msg" >> $at_group_log
> echo "$at_log_msg" >&AS_MESSAGE_LOG_FD
Thanks Nicolas (Hey you doin'? :).
I could not install your patch because of whitespace mismatches.
Please, don't copy paste from a term, and provide a ChangeLog if you
can.
I installed the following.
Index: ChangeLog
from Akim Demaille <address@hidden>
* lib/autotest/general.m4: Use at_times_file only if used.
From Nicolas Joly.
Index: lib/autotest/general.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/autotest/general.m4,v
retrieving revision 1.145
diff -u -u -r1.145 general.m4
--- lib/autotest/general.m4 12 Jun 2003 11:03:56 -0000 1.145
+++ lib/autotest/general.m4 20 Jun 2003 07:51:11 -0000
@@ -1,6 +1,6 @@
# This file is part of Autoconf. -*- Autoconf -*-
# M4 macros used in building test suites.
-# Copyright (C) 2000, 2001, 2002 Free Software Foundation, Inc.
+# Copyright (C) 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -671,11 +671,13 @@
at_log_msg="$at_group. $at_setup_line: $at_msg"
case $at_status in
0|77)
- # $at_times_file is only available if the group succeeded or was
skipped.
- # We're not including the group log, so the success message is written
- # in the global log separately. But we also write to the group log in
- # case they're using -d.
- at_log_msg="$at_log_msg (`sed 1d $at_times_file`)"
+ # $at_times_file is only available if the group succeeded or
+ # was skipped. We're not including the group log, so the
+ # success message is written in the global log separately.
+ # But we also write to the group log in case they're using
+ # -d.
+ $at_times_skip ||
+ at_log_msg="$at_log_msg (`sed 1d $at_times_file`)"
echo "$at_log_msg" >> $at_group_log
echo "$at_log_msg" >&AS_MESSAGE_LOG_FD
@@ -683,9 +685,9 @@
$at_debug_p || rm -rf $at_group_dir
;;
*)
- # Upon failure, include the log into the testsuite's global log.
- # The failure message is written in the group log and then included
- # in the global log.
+ # Upon failure, include the log into the testsuite's global
+ # log. The failure message is written in the group log and
+ # then included in the global log.
echo "$at_log_msg" >> $at_group_log
cat $at_group_log >&AS_MESSAGE_LOG_FD
- Re: CVS autoconf testsuite spurious messages,
Akim Demaille <=