Re: [AUCTeX] Update for TOC parsing

[Vincent Belaïche]

Hello,

> To: address@hidden
> From: address@hidden
> Date: Thu, 22 Nov 2012 19:39:21 +0100
> Subject: Re: [AUCTeX] Update for TOC parsing
> 
> Vincent Belaïche <address@hidden> writes:
> 
> Hi Vincent,
> 
> > As agreed previously, I have ported my contribution for Texinfo TOC
> > parsing to the latest AUCTeX on ACUTEX CVS repo and latest RefTeX on
> > emacs Bazaar repo.
> 
> Great, thanks a lot!
> 
> > For RefTeX I can do the commit myself after your feedback as I have
> > write access.
> 
> Both patches look good to me except that there's some encoding problem
> in the reftex patch. Have a look at the names in the ChangeLog.
> 

It seems that the problem is only in the diff file which I produce with
`bzr diff', probably I should have used some option to `keep binary',
but if I commit the change myself, then I tihnk that there won't be such
issue. Please have a look at:

http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/lisp/ChangeLog

and you see that my name has no encoding issue in the commits which I
did.

> Oh, and the auctex patch makes auctex depend on the reftex version in
> emacs bzr. That's not so good. `Texinfo-reftex-hook' should be a no-op
> when `reftex-section-info-function' and the pre/post regexps aren't
> defined.
> 

Well, I can do that if you really think that there is an issue. However,
I don't think that this is needed: imagine newer Texinfo working with
older reftex, yes the TOC won't work, which anyway is what you have
currently without the change.  But, nevertheless, the user won't have
any such thing like an error message, because anyhow the reftex-mode
won't call the hook (current reftex mode does not call any hook, as far
as I know --- as my proposed change is adding the run-hook).

Furthermore, even though by some devilry the Texinfo hook would be
called, then that would not do any more harm than spuriously defining
those reftex-section-info-function, reftex-section-pre-regexp and
reftex-section-post-regexp variables to some Texinfo specific value,
which anyway older Reftex would ignore.

So, I don't think that there is any issue at all, that would be
different if the hook was reading/not writing the variables.

Maybe however it is problematic that the byte compilation of tex-info.el
does some warnings because it uses some variables defined in reftex?
Please feedback on that one.

Otherwise, my suggestion is to commit the change as it is, and see what
happens. Please feel free for brickbats.

Bye,
  Vincent.

> Bye,
> Tassilo
> 
> 
> _______________________________________________
> auctex mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/auctex