[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[AUCTeX] Re: AUCTeX tool-bar and icons

From: Reiner Steib
Subject: [AUCTeX] Re: AUCTeX tool-bar and icons
Date: Wed, 14 May 2008 22:28:35 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2.50 (gnu/linux)

On Wed, May 14 2008, Ralf Angeli wrote:

> * Angelo Graziosi (2008-05-14) writes:
>> Then : 'new-file' does not appear,
> Perhaps we should remove the `new-file' option again.  

Do you refer to my recent change?  It just change the custom
interface, so it's not relevant to Angelo's report using setq.

> With GTK I don't see a difference between `find-file' and
> `menu-find-file-existing'.  And there is no equivalent in Emacs 21.

We should not refrain from improving the tool bar just to make it
identical under Emacs 21.

>> 'open-file' has as icon the same 
>> which Emacs uses for 'new-file',
> Because clicking the button will actually call the function used by
> Emacs for opening a new file.

I think this is a bug in toolbar-x.  I'd suggest this patch (no
compatibility code for Emacs 21 added, since I can't test it):

--8<---------------cut here---------------start------------->8---
--- toolbar-x.el        10 May 2008 22:03:00 +0200      1.18
+++ toolbar-x.el        14 May 2008 22:13:41 +0200      
@@ -1974,14 +1974,21 @@
 (defconst toolbarx-default-toolbar-meaning-alist
   '((separator :image "sep" :command t :enable nil :help "")
-    (open-file :image ["new" toolbar-file-icon]
+    (new-file :image ["new" toolbar-file-icon]
               :command [find-file toolbar-open]
               :enable [(not (window-minibuffer-p
                              (frame-selected-window menu-updating-frame)))
+              :help ["Specify a new file's name, to edit the file" "Visit new 
+    (open-file :image ["open" toolbar-file-icon]
+              :command [menu-find-file-existing toolbar-open]
+              :enable [(not (window-minibuffer-p
+                             (frame-selected-window menu-updating-frame)))
+                       t]
               :help ["Read a file into an Emacs buffer" "Open a file"])
-    (dired :image ["open" toolbar-folder-icon]
+    (dired :image ["diropen" toolbar-folder-icon]
           :command [dired toolbar-dired]
           :help ["Read a directory, operate on its files" "Edit a directory"])
--8<---------------cut here---------------end--------------->8---

BTW, I don't think that duplication tool tips, images, etc. is a good
idea.  I'd rather use something like Gnus `gmm-tool-bar-zap-list', but
I'm biased, of course (warning: there's no XEmacs compatibility

>> 'dired' is represented by the icon 
>> which Emacs uses for 'open-file',
> Yes, because there is no image for this in Emacs 21.

When using Emacs 21, the user won't miss the icon in AUCTeX.  So we
don't need to care about the missing image.  Using the wrong image is

Bye, Reiner.
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |

reply via email to

[Prev in Thread] Current Thread [Next in Thread]