Re: [PATCH 4/4] rm static buffer in __acl_quote for thread safety

[Mike Frysinger]

On 24 Jan 2024 13:06, Pavel Simovec wrote:
> --- a/include/misc.h
> +++ b/include/misc.h
>  
> -hidden const char *__acl_quote(const char *str, const char *quote_chars);
> +hidden char *__acl_quote(const char *str, const char *quote_chars);

could you put together a malloc attribute for these like our "hidden" ?
we can import ax_gcc_malloc_call.m4 from autoconf-archive to do the
configure-time test.  it could be a sep commit before this one, and
have it update one or two other functions.

__acl_quote has been using static buffers for a long time, so having a
little attribute/compiler warning coverage could help i think.

> +     fprintf(stream, "# file: %s\n", qp=xquote(path_p, "\n\r"));

please don't do inline assignments
-mike

signature.asc
Description: PGP signature